Ticket #4408 (new enhancement)

Opened 22 months ago

Last modified 6 months ago

[patch] [CLA] Form widget: process native elements in addition to widgets

Reported by: guest Owned by: wolfram
Priority: normal Milestone: future
Component: Dijit Version: 0.9
Severity: normal Keywords:
Cc: gizmojo.org, wolfram.kriesing@…, dante, alex

Description

dijit.form.Form.getValues() currently ONLY submits values of widgets inside the form not values of normal form elements, this patch fixes that.

Attachments

form-getValues-fix.diff (1.0 kB) - added by guest 22 months ago.
temporary simple fix, to make it at least work

Change History

Changed 22 months ago by guest

temporary simple fix, to make it at least work

Changed 22 months ago by guest

for the record I proposed the patch wolfram.kriesing@…, guest might not have a CLA :-)

Changed 22 months ago by bill

  • owner deleted
  • summary changed from dijit.form.Form.getValues() temporary fix to [patch] [CLA] dijit.form.Form.getValues() temporary fix
  • component changed from General to Dijit
  • milestone set to 1.1

Changed 22 months ago by guest

Set to milestone 1.1? Why that? If the form elements that are no widgets dont get returned by getValues() the widget will be unusable for those forms not using widgets for all the form elements, as for me for example. In 0.4 that was very well possible. Is my provided quick-fix breaking something that it could not be applied before 1.1?

Changed 21 months ago by bill

  • type changed from defect to enhancement
  • summary changed from [patch] [CLA] dijit.form.Form.getValues() temporary fix to [patch] [CLA] Form widget: process native elements in addition to widgets

Patch looks good but also, the set function needs to handle native elements (in addition to the get function), and test file needs to be updated to check that.

Thanks!

Changed 21 months ago by gizmojo.org

  • cc gizmojo.org added

Changed 21 months ago by bill

  • owner set to wolfram

Hi Wolfram,

Can you update this patch so that:

  • checkboxes and radio buttons work
  • update test_Form.html to have native elements in addition to widgets
  • make setValues() work too

Otherwise we have to say that Form sort-of works for native elements, which I guess is better than nothing, but not ideal.

Thanks!

Changed 19 months ago by dylan

  • cc wolfram.kriesing@… added

Wolfram, please see bill's previous comments... I think getting this fixed for Dojo 1.1 is important.

Changed 18 months ago by wolfram

i will try to get it done for the 1.1beta

Changed 18 months ago by dante

(In [12012]) refs #4408, #5359, #5550 - adds semantic degradable textarea, select, and hidden input types that work with dijit.form.Form

Changed 17 months ago by peller

  • milestone changed from 1.1 to 1.2

Changed 11 months ago by dylan

  • cc dante added

Wolfram, Pete, what's the status of this one?

Changed 10 months ago by bill

  • milestone changed from 1.2 to future

defer dormant enhancements to "future" (they don't look like they're getting fixed soon so might as well mark as such)

Changed 9 months ago by alex

  • cc alex added

Changed 6 months ago by elazutkin

This ticket intersects 100% with #7999 (the form manager in DojoX).

Note: See TracTickets for help on using tickets.