Ticket #4370 (closed enhancement: fixed)

Opened 22 months ago

Last modified 13 months ago

BiDi enable TabContainer

Reported by: peller Owned by: peller
Priority: normal Milestone: 1.0
Component: Dijit Version: 0.9
Severity: normal Keywords: bidi
Cc: yinjun@…, hwcdl@…

Description


Attachments

dijit-bidi-fix-theme-slider-tabcontainer-10425.patch (4.1 kB) - added by peller 22 months ago.
Patch from Justin Yin (IBM, CCLA). This patch only works for Firefox.
dijit-bidi-fix-tabcontainer-10431.patch (2.9 kB) - added by peller 22 months ago.
update from Justin

Change History

Changed 22 months ago by peller

Patch from Justin Yin (IBM, CCLA). This patch only works for Firefox.

Changed 22 months ago by peller

Notes from Justin: Like Slider, TabContainer? uses a so complex structure that some browsers like IE cannot handle it well in RTL direction. To completely solve this, I think maybe we need to rewrite some original implementation code in TabContainer?, which might be very risky.

Changed 22 months ago by peller

update from Justin

Changed 22 months ago by peller

(In [10436]) TabContainer? bidi fixes. Refs #4370

Changed 22 months ago by peller

  • cc yinjun@…, hwcdl@… added

unit tests and FF look good. themeTester in IE is still broken.

Changed 20 months ago by peller

  • status changed from new to closed
  • resolution set to fixed
  • milestone changed from 1.1 to 1.0

opened new ticket #5092 for themeTester issue

Changed 20 months ago by peller

(In [11601]) RTL fix from Evan Huang (IBM) for right-h tab position. Refs #4370

Changed 20 months ago by peller

(In [11607]) Fix iteration over array. Refs #4370

Changed 13 months ago by bill

(In [13987]) Replaces JS hack w/CSS hack. Refs #4370, changesets [11601] and [11607]. !strict

Note: See TracTickets for help on using tickets.