Ticket #4350 (closed defect: fixed)

Opened 11 months ago

Last modified 5 months ago

[dojox.validate] d.validation.tests fails to run most of tests

Reported by: guest Owned by: alex
Priority: normal Milestone: 1.1
Component: TestFramework Version: 0.9
Severity: normal Keywords:
Cc: bookstack@…

Description

Test is against r10412, Firefox 2.0.0.6 on Genoo.

When runTests.html is rendered, all test cases consume NaN ms except isText, isIpAddress. And if I toggle test.f and test.t in tests/creditCard.js as this:

Index: creditcard.js =================================================================== --- creditcard.js (revision 10412) +++ creditcard.js (working copy) @@ -5,12 +5,12 @@

[{

name:"isValidLuhn", runTests: function(tests) {

- tests.t(dojox.validate.isValidLuhn('5105105105105100')); //test string input - tests.t(dojox.validate.isValidLuhn('5105-1051 0510-5100')); //test string input with dashes and spaces (commonly used when entering card #'s) + tests.f(dojox.validate.isValidLuhn('5105105105105100')); //test string input + tests.f(dojox.validate.isValidLuhn('5105-1051 0510-5100')); //test string input with dashes and spaces (commonly used when entering card #'s)

tests.t(dojox.validate.isValidLuhn(38520000023237)); //test numerical input as well tests.f(dojox.validate.isValidLuhn(3852000002323)); //testing failures tests.t(dojox.validate.isValidLuhn(18)); //length doesnt matter

- tests.f(dojox.validate.isValidLuhn(818181)); //short length failure + tests.t(dojox.validate.isValidLuhn(818181)); //short length failure

}

}, {

The dojox.validate.tests.creditcard still succeeded.It is supposed to fail.

Change History

Changed 11 months ago by peller

  • cc bookstack@… added
  • owner changed from alex to dante
  • component changed from TestFramework to Dojox

Changed 11 months ago by dante

  • status changed from new to assigned

Changed 11 months ago by dante

(In [10414]) fixes #4351 - adding dojox.validate.isbn validation checking courtesy bookstack [cla/soc champ]. adds DOH unit tests, that may or may not be validating properly (refs #4350). tests were ported from 0.4 unit tests, and all 'passed' as expected, so didn't double check forced failure. I must have set up the tests wrong, somehow.

Changed 10 months ago by dante

  • summary changed from dojox.validate.tests fails to run most of tests to [dojox.validate] d.validation.tests fails to run most of tests

me wished he'd have never heard of dojox.validate :P

Changed 7 months ago by peller

  • owner changed from dante to alex
  • status changed from assigned to new
  • component changed from Dojox to TestFramework
  • milestone set to 1.1

Changed 5 months ago by dante

  • status changed from new to closed
  • resolution set to fixed

(In [12452]) fixes #4350 - new errors being found via extensive existing unit test using wrong runTest: function()

Note: See TracTickets for help on using tickets.