Ticket #4327 (closed defect: fixed)

Opened 15 months ago

Last modified 14 months ago

SingleQuote in content using iframe transport fails

Reported by: guest Owned by: jburke
Priority: normal Milestone: 1.0
Component: General Version: 0.9
Severity: normal Keywords:
Cc:

Description

Having a single quote in a property of content passed to bind posts only text before single quote in IE.

This is caused by way the hidden input is created in IE:

	var tn;
	if(dojo.isIE){
		tn = dojo.doc.createElement("<input type='hidden' name='"+x+"' value='"+content[x]+"'>");
		fn.appendChild(tn);
	}else{
		tn = dojo.doc.createElement("input");
		fn.appendChild(tn);
		tn.type = "hidden";
		tn.name = x;
		tn.value = content[x];
	}

The value should be set after the element is created.

	var tn;
	if(dojo.isIE){
		tn = dojo.doc.createElement("<input type='hidden' name='"+x+"'>");
	}else{
		tn = dojo.doc.createElement("input");
		tn.type = "hidden";
		tn.name = x;
	}
	tn.value = content[x];
	fn.appendChild(tn);

This bug is also present in 0.4.x. Are we fixing bugs there anymore?

Patch is included.

schallm

Attachments

iframe.patch (0.7 kB) - added by guest 15 months ago.

Change History

Changed 15 months ago by guest

Changed 15 months ago by jburke

  • owner changed from anonymous to jburke
  • milestone set to 1.0

Changed 14 months ago by jburke

  • status changed from new to closed
  • resolution set to fixed

(In [10712]) Fixes #4327. Single quotes in the value where causing trouble. Patch from schallm, CLA on file. Thank you.

Changed 14 months ago by jburke

Fixed in the 0.9 codebase. AFAIK, there are no plans to do another 0.4.x build.

Note: See TracTickets for help on using tickets.