Ticket #4116 (closed defect: fixed)

Opened 16 months ago

Last modified 14 months ago

ComboBox: test/example querying against a URL like foo.php?query=ca

Reported by: bill Owned by: wolfram
Priority: normal Milestone: 1.0
Component: Dijit Version: 0.9
Severity: normal Keywords:
Cc:

Description

Add test file for ComboBox/FilteringSelect? with trivial dojo.data Store that gets data from a URL, like the old incrementalDataStore. Implement URL as PHP code (can copy format in tests/layout/getResponse.php).

Change History

Changed 15 months ago by haysmark

We already have ones that use URLs. Whether it is a static file or a PHP file doesn't matter because the return format is the same . . .

Here is the URL that the test in the nightly uses:

http://archive.dojotoolkit.org/nightly/checkout/dijit/tests/form/comboBoxData.json

It's a URL right? It returns the same thing a PHP file would return right? So I'm not sure what we are supposed to do to prove this ticket is fixed beyond that.

Also, if we do implement a PHP file, it will break offline testing, which is bad.

Changed 15 months ago by bill

It's a URL right? It returns the same thing a PHP file would return right?

No, it's different. A PHP file takes a query and returns the items matching the query. Example:

foo.php?query=a

returns:

[ "alabama", "arizona", "arkansas"]

(or something similar)

That's how people will be using Combobox/FilteringSelect in real life so it's important to test. As I wrote in the bug description, "like the old incrementalDataStore" from 0.4.

Changed 15 months ago by bill

  • summary changed from ComboBox: test/example using URL to ComboBox: test/example querying against a URL like foo.php?query=ca

Changed 14 months ago by bill

See #4597 for store that accesses the server on query, and [10692] for a reference PHP implementation that it can be hooked up to.

Changed 14 months ago by bill

  • owner set to wolfram

Changed 14 months ago by bill

  • status changed from new to closed
  • resolution set to fixed

Fixed by [10875]. Thanks Wolfram!

Note: See TracTickets for help on using tickets.