Ticket #4070 (new enhancement)

Opened 9 months ago

Last modified 4 days ago

Editor: if placed inside a layout widget, have the iframe area take up available space.

Reported by: ttrenka Owned by: liucougar
Priority: normal Milestone: 1.2
Component: Editor Version: 0.9
Severity: normal Keywords: mail
Cc:

Description

If a dijit.Editor is placed inside a layout widget, we'd love for the editable area to take up as much space as possible...similar to the way you can assign layoutAlign="client" on a child pane within a LayoutContainer?.

Attachments

test_Editor_resize.html (1.0 kB) - added by BryanForbes 9 days ago.
Drop this in dijit/tests in trunk.
RichEditBC.patch (5.6 kB) - added by guest 4 days ago.

Change History

Changed 9 months ago by bill

  • component changed from Dijit to Editor
  • summary changed from dijit.Editor: if placed inside a layout widget, have the iframe area take up available space. to Editor: if placed inside a layout widget, have the iframe area take up available space.

This amounts to having a resize(size) method that gives the toolbar 20px (or however much space it needs) and gives the remaining space to the iframe.

Changed 9 months ago by bill

  • keywords mail added

Changed 2 months ago by dylan

  • milestone changed from 1.1 to 1.2

mass move of editor issues to 1.2.

Changed 9 days ago by bill

See also #6703.

Changed 9 days ago by BryanForbes

Drop this in dijit/tests in trunk.

Changed 6 days ago by liucougar

  • status changed from new to closed
  • resolution set to fixed

add height="100%" to the editor, and it should work just fine

Changed 6 days ago by liucougar

  • status changed from closed to reopened
  • resolution deleted

forgot to mention: in order for that to work, you need to manually add a toolbar to the "top" region, and pass that toolbar to the editor (this is a bit hard to do in markup though)

alternatively, editor may be changed to use a bordercontainer to do the layout of the editing area and the toolbar (then the editor needs to propogate startup/layout calls to the underlying bordercontainer). Bill, what do you think?

Changed 4 days ago by bill

So, first of all, I don't want to force developers using dijit to put the Toolbar in a separate pane, etc.... that should be builtin to Editor the same way that TabContainer puts the tab labels on the top of the available space.

As per making editor use a BorderContainer internally, it sounds like overkill to me... all that is really needed is that when Editor.resize({w: 500, h: 500}) is called, give whatever height is needed to the toolbar, and then give the remaining height to the contentEditable div.

Changed 4 days ago by liucougar

  • owner changed from alex to liucougar
  • status changed from reopened to new

Changed 4 days ago by guest

Changed 4 days ago by guest

You are welcome to use any of my diffs to make RichEditor? use a BorderContainer?. Probably needs cleaning up and a regression test, which I don't have time to make, sorry. I have a Dojo CLA under "Laurence A. Lee".

-lalee

Note: See TracTickets for help on using tickets.