Ticket #3961 (reopened defect)

Opened 11 months ago

Last modified 2 weeks ago

[meta] base size reductions

Reported by: alex Owned by: anonymous
Priority: normal Milestone: 1.2
Component: Core Version: 0.9
Severity: normal Keywords:
Cc: alex

Description

Base is getting pretty piggy (70K post ShrinkSafe?, 23K gzipped). It may be unreasonable to hit the 50K ceiling without packing, but we should clearly be much closer to it. This is a catch-all but for size-reduction checkins for 0.9

Attachments

lang-fx-reduction.patch (6.5 kB) - added by peller 9 months ago.
Remove fx defaultEasing hack for old Konqueror (fixed in 3.5.5, according to mumme) Also remove unneeded instance defaults on prototype, other style and size changes
xhr-rpc-reduction.patch (11.3 kB) - added by peller 9 months ago.
another ~200 bytes. Throw if json filtered comment fails.
cleanup.patch (4.3 kB) - added by dante 2 weeks ago.

Change History

Changed 11 months ago by alex

(In [9936]) slight variable factoring for size. Refs #3961

Changed 11 months ago by alex

(In [10146]) size reductions for NodeList?. Refs #3961

Changed 11 months ago by alex

(In [10147]) clobber cruft function. Refs #3961

Changed 11 months ago by alex

(In [10148]) no one's using "makeCalled()". Removing it. Refs #3961

Changed 11 months ago by alex

(In [10149]) size optimizations for loader. Refs #3961

Changed 11 months ago by alex

(In [10150]) make sure that the doc system picks up _getText but that we don't pay for it otherwise. Refs #3961

Changed 11 months ago by alex

(In [10151]) some size-related changes and a bit of crusty function removal. Refs #3961

Changed 11 months ago by alex

(In [10199]) trimming cruft from dojo.Deferred. The toString() was especially useless. Refs #3961

Changed 11 months ago by alex

(In [10200]) eliminates the native branch for dojo.* array methods. There wasn't a perceptable or testable speed difference and it cost us in bytes. Refs #3961

Changed 11 months ago by peller

(In [10203]) pick up a couple more bytes from array. Use xor bitwise logic on booleans. Refs #3961

Changed 11 months ago by peller

(In [10206]) Use new docparser comment feature for 'faux declaration'. Refs #3961

Changed 11 months ago by peller

(In [10207]) Fix typo I made in 'faux declaration' of getComputedStyle. Refs #3961

Changed 10 months ago by peller

  • status changed from new to closed
  • resolution set to fixed

(In [10475]) Add comments for isObject plus style mods. Fixes #4424, #3961

Changed 10 months ago by peller

  • status changed from closed to reopened
  • resolution deleted

oops. didn't mean to close.

Changed 10 months ago by peller

(In [10589]) Style and space fix for dojo.isArrayLike. Refs #3961

Changed 9 months ago by peller

Remove fx defaultEasing hack for old Konqueror (fixed in 3.5.5, according to mumme) Also remove unneeded instance defaults on prototype, other style and size changes

Changed 9 months ago by peller

(In [10659]) Reductions for _base, including:

* removal of unnecessary typeof foo != "undefined" pattern * removal of Konqueror workaround (fixed in 3.5.5: http://bugs.kde.org/show_bug.cgi?id=126482) * removal of unnecessary instance defaults on prototype object

Refs #3961

Changed 9 months ago by peller

another ~200 bytes. Throw if json filtered comment fails.

Changed 9 months ago by peller

(In [10834]) some code reductions. Refs #3961. Throw if json filtered comment fails.

Changed 8 months ago by peller

(In [11157]) I give up. Put back the indexOf searches for comments in place of regexp attempt. Refs #3961, #4829, #4888 Reverts part of change in [10834]

Changed 8 months ago by alex

(In [11205]) make the bootstrap smaller through scope protection closures now that the doctool is picking everything up. Big props to Neil for making this possible (and safe). Refs #3961

Changed 8 months ago by alex

(In [11212]) updating for removed "!=" selector in dojo.query. Also, size reductions. Refs #3961

Changed 8 months ago by alex

(In [11214]) ugg. I keep forgetting to re-enable the query optimizer! Refs #3961

Changed 8 months ago by alex

(In [11219]) minor nits. Refs #3961. I'm still very unhappy about how much space the gears detection code takes up.

Changed 8 months ago by alex

(In [11225]) clean up doc formatting and a bit of structure. Also some code size reductions. Refs #4820. Refs #3961

Changed 8 months ago by jburke

(In [11245]) Refs #3961. requireInto is not ready for prime time yet. In particular, it will not work with xd loading. Removing for now, to help reduce base.

Changed 8 months ago by peller

  • milestone changed from 1.0 to 1.1

so we're locking down 1.0. moving to 1.1 for continued work, or do we close this and just use it as a checkin reference?

Changed 6 months ago by dante

(In [12108]) refs #3961 - tiny tiny cleanup to parser, and note on usage of dojo/method dojo/event

Changed 5 months ago by peller

(In [12224]) remove deprecated argument juggling in declare.js. style fixes. !strict Refs #3961

Changed 5 months ago by peller

(In [12376]) Reduce toPixelValue with a regexp, remove redundant return statements. Refs #3961 !strict

Changed 5 months ago by peller

(In [12377]) Remove wildcards in toStyleValue regexp. Still just as accurate as it was before. Refs #3961 !strict

Changed 5 months ago by peller

(In [12378]) One more time... don't assume pos=0 Refs #3961 !strict

Changed 5 months ago by peller

(In [12379]) Don't need to seed cache with width/height. Refs #3961 !strict

Changed 5 months ago by alex

(In [12418]) drop base size a bit. Refs #3961

Changed 4 months ago by alex

(In [12798]) lastIndexOf() was totally borked. This fixes, rolling back changes from r10203. Refs #3961. !strict

Changed 4 months ago by alex

(In [12818]) shorten NodeList? code, add toggleClass(), and update documentation. Refs #4205. Refs #3961. !strict

Changed 4 months ago by alex

  • summary changed from Base size reductions to [meta] base size reductions

Changed 4 months ago by alex

(In [12828]) comment cleanup and code shortening. Also expanding test cases to handle default param packing. Refs #3961. Refs #5962. Refs #3121. !strict

Changed 3 months ago by bill

  • milestone changed from 1.1 to 1.2

Move all milestone 1.1 tickets to 1.2, except for reopened tickets and tickets opened after 1.1RC1 was released.

Changed 2 weeks ago by alex

(In [14051]) getting even more miserly w/ the bytes. Refs #3961 !strict

Changed 2 weeks ago by alex

(In [14052]) some more byte scrimping. Refs #3961 !strict

Changed 2 weeks ago by dante

Changed 2 weeks ago by dante

i've added cleanup.patch [cla/me] -- was looking for sanity check / approval before committing. moves dojo css-class functions into anon function, re-uses the defined "d" variable, and "obfuscates" the use of the .className property by making it a string (once) and refing the variable in each of the three functions. shaves some bytes but only after shrinkSafe makes a pass and renames it to _01 or something.

please review. unit tests for html pass FF3, ie6 + 7 ... is a trivial patch ultimately. (quite a few ie6 DOH failures in other places though I notice ... )

Note: See TracTickets for help on using tickets.