Ticket #3874 (closed enhancement: fixed)

Opened 12 months ago

Last modified 5 months ago

dojo.marginBox() doesn't work with default border width

Reported by: jaredj Owned by: sjmiles
Priority: normal Milestone: 1.1
Component: HTML Version: 0.9
Severity: normal Keywords:
Cc:

Description (last modified by bill) (diff)

Original description:

Using 0.9 LayoutContainer? and ContentPanes?, it appears that in IE 6 the right edge of the stuff in the content panes are clipped off the view. In FireFox? and Safari it's fine.

I made a testcase that shows this. It's actually from some doc I've been working on and discovered the clipping issue.

Note from Bill: It's a problem with dojo.marginBox() when the border width isn't specified. The border width defaults to the string "medium", which is 4px, but dojo._toPixelValue(node, "medium") returns 0 (rather than 4).

Attachments

multi_viewlayout.html (2.9 kB) - added by jaredj 12 months ago.
Testcase that shows the clipping issue.

Change History

Changed 12 months ago by jaredj

Testcase that shows the clipping issue.

Changed 12 months ago by jaredj

  • owner changed from anonymous to bill
  • component changed from General to Dijit
  • type changed from defect to task

Changed 12 months ago by bill

  • milestone set to 0.9

Changed 12 months ago by jaredj

Clarification of what is clipping. The border on the contentpane/div. I have CSS styles set to mae a 3dlike border on them, and the right edge one gets clipped off in IE. It's visible in Firefox and Safari.

Changed 12 months ago by bill

  • owner changed from bill to sjmiles
  • component changed from Dijit to HTML
  • description modified (diff)
  • summary changed from 0.9: ContentPanes in IE 6 appear to clip the right edge of the contents. to dojo.marginBox() doesn't work with default border width

Changed 12 months ago by sjmiles

  • status changed from new to assigned
  • type changed from task to enhancement
  • milestone changed from 0.9 to 1.0

This is a known issue (comments to that effect are in the code I believe).

The current system requires a border style to be given an explicit width.

It may be possible to reliably convert some of these textual values into pixel values, so I'm going to mark this ticket as an enhancement for 1.0.

Changed 12 months ago by sjmiles

(In [10186]) Make toPixelValue translate 'medium' to 4, hack refs #3874.
Repair scrolling adjustment in _abs, fixes #3455.

Changed 5 months ago by sjmiles

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.