Ticket #3552 (closed defect: fixed)

Opened 17 months ago

Last modified 17 months ago

Refactor/clean-up html.js

Reported by: sjmiles Owned by: sjmiles
Priority: normal Milestone: 0.9beta
Component: General Version: 0.9
Severity: normal Keywords:
Cc:

Description

html.js has gathered moss over the last few months. Various clean up tasks are needed.

Change History

Changed 17 months ago by sjmiles

  • status changed from new to assigned

Changed 17 months ago by sjmiles

(In [9341]) Refactoring of html.js. Refs #3552.

Changed 17 months ago by sjmiles

Various tasks were performed in r9341, including:

* _setContentBox renamed _setContentSize. Left/top are ill-defined in this context. * contentBox in "setting mode" therefore now ignores left/top. * _getPadBounds renamed _getPadExtents for consistency. * _getBorderExtents and _getBorderBox added. * factored _usesBorderBox test into a function * adjusted various methods for browser quirks, documented inline

Refer also to #3454 and #3515.

Changed 17 months ago by sjmiles

Sorry, failed to preview my bullet points above. Repaired edition:

  • _setContentBox renamed _setContentSize. Left/top are ill-defined in this context.
  • contentBox in "setting mode" therefore now ignores left/top.
  • _getPadBounds renamed _getPadExtents for consistency.
  • _getBorderExtents and _getBorderBox added.
  • factored _usesBorderBox test into a function
  • adjusted various methods for browser quirks, documented inline

Changed 17 months ago by sjmiles

  • status changed from assigned to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.