Ticket #2844 (closed defect: fixed)

Opened 19 months ago

Last modified 16 months ago

Formbind bug in IE6: html input field named action

Reported by: guest Owned by: jaredj
Priority: normal Milestone:
Component: IO Version: 0.4.2
Severity: normal Keywords:
Cc:

Description

Hi there, I hope, this hasn't been reported before:

Formbind has a problem with form elements having an ID or name called "action", e.g.

<input type="hidden" id="action" name="action" value="acquire_post">

Submitting this form via Formbind works fine with Firefox but does not on IE6. After onSubmit returns true, I receive the output below. I couldn't believe it myself, but renaming that field to my_action solved the problem.

Debug Output: [TypeError: Object doesn't support this property or method] when calling submit$joinpoint$method on [object Object] with arguments [object Object] FATAL exception raised: Object doesn't support this property or method"

Thanks! Dirk

Attachments

dojo_0.4.3_formbind_bug.patch (2.4 kB) - added by jaredj 16 months ago.
dojoform.html (3.4 kB) - added by jaredj 16 months ago.
dojo.io.FormBind_0.4.X_20070723.patch (6.3 kB) - added by jaredj 16 months ago.
dojo.io.IFrameIO_20070724.patch (1.5 kB) - added by jaredj 16 months ago.
dojo_0.9_xhrForm_20070724.patch (3.4 kB) - added by jaredj 16 months ago.
Patch to 0.9 + UT for form handling issue.

Change History

Changed 16 months ago by jaredj

This problem was also hit by a co-worker of mine. It occurs in IE on calls that do:

kwArgs.formNode.getAttribute("action");

In the IO code for Browser, scriptsrc, and IFrame. The fix is also pretty darn simple. I'll be attaching a testcase, plus patch, for 0.4.X to this bug. 0.9 should also be checked out for issues as I suspect it also likely has them in the _base/xhr.js code.

Note I'm under CLA through my company so the patch is safe. :-)

Changed 16 months ago by jaredj

Changed 16 months ago by jaredj

Changed 16 months ago by jaredj

Changed 16 months ago by jaredj

(In [9756]) Putting in a patch for #2844 handling of node.getAttribute() on IE. refs #2844

Changed 16 months ago by jaredj

  • owner changed from alex to jaredj

Changed 16 months ago by jaredj

The above for 0.4.X was tested on:

Firefox 2.0.0.5 Firefox 1.5.0.12 IE 6.0 IE 7.0 Safari B3 Opera 9.2 Seamonkey 1.1.2 Mozilla 1.7.13

Next to work on is to verify if 0.9 has similar issues, and patch them if so.

Changed 16 months ago by jaredj

Follow on patch needed for IFrameIO. More experiments revealed it needs to do setting via the returned nodes as well. so ... this gets a bit uglier for IFrameIO. *sigh*. Patch will be attached shortly.

Changed 16 months ago by jaredj

Changed 16 months ago by jaredj

(In [9771]) Followon patch to deal with IE issues and form attributes. refs #2844

Changed 16 months ago by jaredj

Patch to 0.9 + UT for form handling issue.

Changed 16 months ago by jaredj

  • status changed from new to closed
  • resolution set to fixed

(In [9776]) Patch to 0.9 for form handling issue. fixes #2844

Changed 16 months ago by jaredj

Tested for 0.4.X on: Firefox 2.0.0.5 Safari B3 IE 6 Seamonkey 1.1.2 Opera 9.2

Tested for 0.9 on: IE 6 Safari B3 Forefox 2.0.0.5 Opera 9.2 Seamonkey 1.1.2

Changed 16 months ago by guest

Note: See TracTickets for help on using tickets.