Ticket #2606 (closed defect: fixed)

Opened 17 months ago

Last modified 14 months ago

build process does not strip dojo.requireIf statements

Reported by: jburke Owned by: jburke
Priority: normal Milestone:
Component: BuildSystem Version: 0.4.2
Severity: normal Keywords:
Cc:

Description

This happens in 0.4.2.

Steps to reproduce: - Build dojo using the buildscripts/profiles/charting.profile.js profile. - After the build is done, open tests/charting/test_engine.html - Look at the Firebug console. You will see some requests for some svg modules, but they are already included in dojo.js.

The build process should be removing dojo.requireIf() calls if the module that is referenced by the dojo.requireIf() call is in the built dojo.js.

Change History

Changed 17 months ago by jburke

  • milestone set to 0.9M1

Changed 17 months ago by jburke

  • status changed from new to closed
  • resolution set to fixed

(In [7629]) Fixes #2606, dojo.requireIf calls not being stripped from built dojo.js

Changed 17 months ago by jburke

  • status changed from closed to closed
  • resolution set to fixed

(In [7630]) (merge from 0.4 branch) Fixes #2606, dojo.requireIf calls not being stripped from built dojo.js

Changed 16 months ago by jburke

  • milestone changed from 0.9M1 to 0.4.3

Changed 16 months ago by jburke

  • status changed from closed to reopened
  • resolution deleted

Reopening -- this change is too aggressive: it seems to be removing all requireIf statements, but it should only remove the ones for modules that are in the built file.

Changed 16 months ago by jburke

  • status changed from reopened to closed
  • resolution set to fixed

(In [8071]) Fixes #2606. Forgot to escape regexp sensitive characters in the dependency string.

Changed 16 months ago by jburke

  • status changed from closed to closed
  • resolution set to fixed

(In [8072]) (merge from 0.4 branch) Fixes #2606. Forgot to escape regexp sensitive characters in the dependency string.

Changed 16 months ago by jburke

  • status changed from closed to closed
  • resolution set to fixed

(In [8073]) (merge from 0.4 branch) Fixes #2606. Forgot to escape regexp sensitive characters in the dependency string.

Changed 14 months ago by anonymous

  • milestone deleted

Milestone 0.4.3 deleted

Note: See TracTickets for help on using tickets.