Ticket #2542 (closed defect: fixed)

Opened 18 months ago

Last modified 11 months ago

[dojo.data] change datastores to use SimpleBaseStore

Reported by: skinner Owned by: jaredj
Priority: normal Milestone: 1.0
Component: Data Version: 0.4.1
Severity: minor Keywords:
Cc:

Description

We should convert a lot of the dojo.data datastores to inherit from dojo.data.core.SimpleBaseStore?. A number of our older datastore implementations were written back before SimpleBaseStore? existed. Now that we have SimpleBaseStore?, we should use it as a standard abstract superclass for most of those older datastores. The datastores implementations will be simpler and more consistent after the change.

Here's what that current inheritance hierarchy looks like:

+ OpmlStore extends nothing
+ SimpleBaseStore extends nothing
   + JsonItemStore extends SimpleBaseStore
+ RemoteStore extends nothing
   + CsvStore extends RemoteStore
   + DeliciousStore extends RemoteStore
   + YahooStore extends RemoteStore 
   + RdfStore extends RemoteStore 

Here's what I think a better inheritance hierarchy would look like:

+ SimpleBaseStore extends nothing
   + JsonItemStore extends SimpleBaseStore
   + OpmlStore extends SimpleBaseStore
   + CsvStore extends SimpleBaseStore
   + DeliciousStore extends SimpleBaseStore
   + YahooStore extends SimpleBaseStore
   + RemoteStore extends SimpleBaseStore 
      + RdfStore extends RemoteStore 

Attachments

dojo.data.util.simpleFetch_20070429.patch (1.5 kB) - added by guest 16 months ago.
Corrected documentation in the simpleFetch utility function
dojo.data.util.sorter_20070429.patch (0.8 kB) - added by guest 16 months ago.
Modified basicComparator to handle undefined values
dojox.data.CsvStore_20070429.patch (42.4 kB) - added by guest 16 months ago.
First implementation of the CsvStore? in the dojox branch, includes UT
dojo.data.api.Read_20070501.patch (1.3 kB) - added by guest 16 months ago.
Two trivial corrections to documentation on the dojo.data.api.Read interface.
dojox.data.CsvStore_20070501.patch (43.0 kB) - added by guest 16 months ago.
Second revision of dojox.data.CsvStore? implementation.
dojox.data.OpmlStore_20070515.patch (38.0 kB) - added by guest 15 months ago.
OpmlStore? patch and UT files
dojox.data.OpmlStore_20070518.patch (38.1 kB) - added by guest 15 months ago.
Round 2 of the OpmlStore? implementation

Change History

Changed 16 months ago by guest

Corrected documentation in the simpleFetch utility function

Changed 16 months ago by guest

Modified basicComparator to handle undefined values

Changed 16 months ago by guest

First implementation of the CsvStore? in the dojox branch, includes UT

Changed 16 months ago by guest

The three patches uploaded on 4/29 were created by me (Michael Smith, msmith [CLA]).

This is the initial port of CsvStore? into dojox, using simpleFetch as a mixin class for the CsvStore?.

The modification to basicComparator is required for the "sort" Unit Tests to pass.

Data types are not yet implemented, so sorting numbers is lexicographic.

~Michael Smith (msmith)

Changed 16 months ago by guest

Two trivial corrections to documentation on the dojo.data.api.Read interface.

Changed 16 months ago by guest

Second revision of dojox.data.CsvStore? implementation.

Changed 16 months ago by guest

Two more patches uploaded by Michael Smith (msmith).

Changed 16 months ago by jaredj

(In [8397]) Applying two patches from Michael Smith for minor documentation updates (dojo.data.util.simpleFetch_20070429.patch and dojo.data.api.Read_20070501.patch). refs #2542

Changed 16 months ago by jaredj

(In [8398]) Committing in Michael Smith patch for CsvStore? port to dojox.data and UT. Minor updtae to patch by Jaredj to remove a couple bits of whitespace. refs #2542

Changed 16 months ago by jaredj

The CsvStore? addition was tested against:

Windows: Firefox 2.0.0.3 Firefox 1.5.0.11 IE 6 IE 7 Opera 9.2

OS-X: WebKit?

Changed 15 months ago by guest

OpmlStore? patch and UT files

Changed 15 months ago by guest

Attached the OpmlStore? patch with unit tests. This is a first pass patch that will probably need to be updated before committing it into dojox.

~Michael Smith (msmith)

Changed 15 months ago by guest

Round 2 of the OpmlStore? implementation

Changed 15 months ago by jaredj

(In [8670]) Commit of theOpmlStore patch from Michael Smith. refs #2542

Changed 13 months ago by jaredj

  • owner changed from skinner to jaredj

Changed 13 months ago by jaredj

  • milestone changed from 0.9 to 1.0

Changing this to 1.0. We've ported the main stores over and added Flickr. so delicious isn't as important now and could be ported in 1.0 timeframe.

Changed 11 months ago by jaredj

  • status changed from new to closed
  • resolution set to fixed

We've proted everything I think we're going to port for now. Closing thos.

Note: See TracTickets for help on using tickets.