dojo.lfx.html.wipeIn sets node height incorrectly with compressed dojo build

[jwiltshire@…]

The wipeIn animation causes the size of the node it is animating to continually increase in size every time the animation is called. This only occurs when the following 2 conditions are met: * The DOM node being animated has a non-zero border style (i.e. style="border:1px solid black;" * The page is using a compressed dojo file that has the dojo.lfx.* module included in it. Using an uncompressed dojo build, or loading the module via dojo.require works fine.

I traced this down to the use of 'height' as a variable name, and the subsequent use of 'height' within a 'with (node.style)' block. The compressor seems to be incorrectly replacing the 'height' reference within the with block (which should refer to node.style.height) to the local variable reference.

Here's an extract of the source from dojo/lfx/html.js:

var height= dojo.html.getBorderBox(node).height;
...
anim.connect("beforeBegin", function(){
...
with(node.style){
	overflow = "hidden";
	height = "1px"; // 0 causes IE to display the whole panel
}

The compressed version of this then becomes:

var _41b=dojo.html.getBorderBox(node).height;
...
anim.connect("beforeBegin",function(){
...
with(node.style){
overflow="hidden";
_41b="1px";
}

...when in fact it should be:

var _41b=dojo.html.getBorderBox(node).height;
...
anim.connect("beforeBegin",function(){
...
with(node.style){
overflow="hidden";
height="1px";
}

Renaming the 'height' var to 'nodeHeight' resolves the problem.

[jwiltshire@…]

Test case that demonstrates the problem

[jwiltshire@…]

Patch that resolves the issue

[jwiltshire@…]

This issue has also been raised as http://trac.dojotoolkit.org/ticket/2321

[alex]

accepting for 0.4.2

[alex]

(In [7515]) fixes #2489

[anonymous]

Milestone 0.4.2 deleted