[testcase] dojo.clone mangles object methods during clone

[guest]

Steps to reproduce:

 o = {}
[object Object]
>>> o.f = function () {dojo.debug("SSS");}
function () {...}
>>> o2 = dojo.lang.shallowCopy(o, true)
[object Object]
>>> o.f()
SSSdojo.js (line 237)
>>> o2.f()
>>> o2 = dojo.lang.shallowCopy(o, false)
[object Object]
>>> o2.f()
SSS

Dojo 0.4.1 on Firefox 2.0/Ubuntu Linux 6.10

My contact info: apa3a at yahoo dot com

[peller]

Still a problem in 1.x

>>>f2=dojo.clone(function(){console.log("foo");})
foo
anonymous()
>>>f2
anonymous()
>>>f2() // f2 is a function created from Function.constructor; it doesn't do anything

[dylan]

The testcase provided by peller is still an issue.

[bill]

Move all milestone 1.1 tickets to 1.2, except for reopened tickets and tickets opened after 1.1RC1 was released.

[matsuri]

what ive done

i have 3 patches maybe solving the problem

1. dojo._base.lang.clone: i added a part to clone functions (was missing before)

2. dojo.tests._base.lang: i outcommented the error throwing part (with the function)

3. util.doh.runner: i implemented a funcEq function (which is very simple and surely not enough.. but i dont know better now) and adjusted the assertEqual method

what should probably be done next

• testing the stuff by an experienced person (knowing all the js func secrets i dont know)
• maybe adding the funcEq to the other asserts

[bill]

as per today's meeting, punting these core bugs