Editor: Update (Insert) Image not functional in IE6sp2

[tdedischew@…]

Test Case: http://download.dojotoolkit.org/release-0.4.1/dojo-0.4.1-kitchen_sink/tests/widget/Editor/test_Editor2.html

Add an image to one of the Editor2's via the toolbar or cut/paste of html (say http://dojotoolkit.org/img/page-title-smaller.png), then select that image and hit the toolbar icon again to modify.

Regardless of any property changes, when you hit Ok, you'll get a javascript error in IE6 (line 4971 Object doesn't support this property or method).

The exception is happening during the inserthtml execCommand...

I have to find a solution this weekend (or scrap using Editor2) so will hopefully post a fix shortly. I couldn't find this bug logged elsewhere in trac, but maybe someone has encountered this strange IE/Editor2 behavior before?

[tdedischew@…]

Current solution is to nuke the existing image node (explicit delete+insert vs. relying on the implied replacement via the "inserthtml" command)...

		if(this.imageNode){
			dojo.withGlobal(curInst.window, "selectElement", dojo.html.selection, [this.imageNode]);
			/* if IE, nuke node -- 'cursor' remains where node was, 
			   so this seems safe and the later inserthtml command
			   inserts right where the old image was... */
			if (dojo.render.html.ie)
			  curInst.execCommand('delete');
		}

[liucougar]

0.9 editor does not yet have an image dialog plugin, punt this

[peller]

(In [12335]) First stab at porting the old url 'insertImage' dialog feature from 0.4. Refs #2439 Uses same code as 'createLink' in LinkDialog? plugin. A fancy dojox.image plugin might extend this. Refs #5759. Also, cleanup code in LinkDialog?.js.

[alex]

we should verify and fix/spike for 1.1

[peller]

generally working. have some other tickets open to track issues.

[peller]

(In [12770]) Remove 'experimental.' Refs #2439, #4171, #4971

[peller]

(In [12771]) Oops. Remove log. Refs #2439