[patch][cla] Reduce dojo.lang.reduce

[peller]

The attached patch (and test) clears up several problems with dojo.lang.reduce:

• the "lenght" typo
• the fact that the arr.shift() is destructive on the argument passed in
• removes bloat to check for an invalid call of arg length = 1
• arg length 3 and the default case seem to be redundant
• reorders the arg list to be more sane and reduce the code and api complexity (we can get away with it in 0.9)

I don't understand the history here so I'm assigning to Alex for review.

Thanks to Josh Staiger, IBM (CCLA)

[peller]

new code for dojo.lang.reduce

[peller]

unit tests

[alex]

Josh, Adam, great patch.

[peller]

Alex -- just to point out that the patch implies an incompatible API change, recommended for 0.9. For 0.4.2, perhaps we could just fix the lenght typo? That's about as low risk as we can get :)

[alex]

(In [7563]) refs #2414

applying the bits of Josh Staiger's patch that can be safely used in 0.4.x code. Will apply the full patch to trunk, but I'll be counting on Josh or Adam to fill in the porting guide for this function

[alex]

(In [7564]) refs #2414

[alex]

(In [7565]) fixes #2414

[anonymous]

Milestone 0.4.2 deleted