Ticket #2404 (closed enhancement: fixed)

Opened 22 months ago

Last modified 18 months ago

intern-strings should intern all strings in widget files

Reported by: jburke Owned by: jburke
Priority: normal Milestone:
Component: BuildSystem Version: 0.4.1
Severity: normal Keywords:
Cc:

Description

Right now, when intern-strings is run, only dojo.js and the .xd.js files get strings interned. However, the normal .js files that are not part of dojo.js should also have strings interned too, just as we flatten all resource bundles to improve load speed of builds.

Change History

Changed 22 months ago by jburke

  • status changed from new to closed
  • resolution set to fixed

(In [7186]) Fixes #2301 and #2404, and references #2366. web built dojo.js now has strings interned, and for regular builds, all widget js files have strings interned now for the intern-strings target. To get those things to work, I moved the internStrings.js functions into buildUtil.js, but I did it slightly differently than the patch in #2301.

Changed 22 months ago by jburke

  • status changed from closed to closed
  • resolution set to fixed

(In [7187]) (merge from 0.4 branch) Fixes #2301 and #2404, and references #2366. web built dojo.js now has strings interned, and for regular builds, all widget js files have strings interned now for the intern-strings target. To get those things to work, I moved the internStrings.js functions into buildUtil.js, but I did it slightly differently than the patch in #2301.

Changed 18 months ago by anonymous

  • milestone deleted

Milestone 0.4.2 deleted

Note: See TracTickets for help on using tickets.