Ticket #2318 (closed defect: fixed)

Opened 23 months ago

Last modified 18 months ago

dnd error on contentpane loading (0.4.1 regression)

Reported by: frax.free@… Owned by: alex
Priority: normal Milestone:
Component: DnD Version: 0.4.1
Severity: major Keywords: dnd, contentpane
Cc:

Description

Hi, In the main page of a html document, I defined a 'standard' contentpane : <div dojoType="ContentPane?" id="center_subPanel" executeScripts="true" cacheContent="false" refreshOnShow="true" sizeMin="60" sizeShare="60" style="overflow:auto;padding-bottom:5px;"

In my js library, its content is loaded with the setUrl function :
var center_subPanel = dojo.widget.byId('center_subPanel');
center_subPanel.domNode.style.display = 'block';
dojo.event.connect(center_subPanel , 'onLoad' , 'end_onLoad');
center_subPanel.setUrl(url);

To try the Dnd API implementation, I used the provided dojo's html file 'tests/dnd/test_simple.html.'
Everything works fine with the 0.4.0 release. But with the 0.4.1 release, an error appears when loading the pane content : 'this.dropTargets is null', HtmlDragManager?.js, line 135.

Change History

Changed 22 months ago by guest

Hi, In the main page of a html document, I defined a 'standard' contentpane : <div dojoType="ContentPane?" id="center_subPanel" executeScripts="true" cacheContent="false" refreshOnShow="true" sizeMin="60" sizeShare="60" style="overflow:auto;padding-bottom:5px;" >

In my js library, its content is loaded with the setUrl function : var center_subPanel = dojo.widget.byId('center_subPanel'); center_subPanel.domNode.style.display = 'block'; dojo.event.connect(center_subPanel , 'onLoad' , 'end_onLoad'); center_subPanel.setUrl(url);

To try the Dnd API implementation, I used the provided dojo's html file 'tests/dnd/test_simple.html.' So we have : center_subPanel.setUrl('tests/dnd/test_simple.html'); Everything works fine with the 0.4.0 release. But with the 0.4.1 release, an error appears when loading the pane content : 'this.dropTargets is null', HtmlDragManager??.js, line 135.

Changed 22 months ago by dylan

  • priority changed from high to normal
  • summary changed from dnd error on contentpane loading (0.4.1) to dnd error on contentpane loading (0.4.1 regression)
  • milestone set to 0.4.2

Changed 22 months ago by mignon

I think the fix is to insert the following line in src/dnd/HtmlDragManager.js after line 61 (or thereabouts):

dropTargets: [],

Changed 22 months ago by skinner

(In [7288]) References #2318. I just applied Mignon's suggested fix, which Dylan had approved. Maybe we can close this ticket now, but somebody who knows more about dojo.dnd should decide that.

Changed 22 months ago by skinner

(In [7289]) (merge from 0.4 branch) References #2318. I just applied Mignon's suggested fix, which Dylan had approved. Maybe we can close this ticket now, but somebody who knows more about dojo.dnd should decide that.

Changed 22 months ago by alex

  • status changed from new to closed
  • resolution set to fixed

Brian, Mignion, thanks for finding this!

Changed 18 months ago by anonymous

  • milestone deleted

Milestone 0.4.2 deleted

Note: See TracTickets for help on using tickets.