Ticket #2301 (closed enhancement: fixed)

Opened 23 months ago

Last modified 18 months ago

Patch to re-work buildscripts/internStrings.js main code into buildUtil.js

Reported by: cameron@… Owned by: jburke
Priority: normal Milestone:
Component: BuildTools Version: 0.4.1
Severity: normal Keywords:
Cc:

Description

I use an external tool (a java program) to generate my builds.

I was using an embeded python interpreter to call the python version of regexpMagic.

regexpMagic has now been converted to javascript in internStrings.js

The attached patch moves the functions from internStrings.js into buildUtil.js as members of buildUtil to allow them to be used separate from internStrings.js

Attachments

dojo-0.5-move-internStrings-to-buildUtil.patch (13.3 kB) - added by cameron@… 23 months ago.

Change History

Changed 23 months ago by cameron@…

Changed 23 months ago by bill

  • owner changed from anonymous to jburke
  • component changed from General to BuildTools

Changed 23 months ago by jburke

  • milestone set to 0.5

Thanks for the patch. I was hoping to move all the functions out of the top-level script entry points, but I haven't gotten around to it. I'll be picking this change up in the next couple of weeks. Is that timeframe OK, or would it be better for you if I apply the change sooner than later?

Changed 23 months ago by cameron

It doesn't really bother me.

I'm happy to do my builds using my patched version in the mean time.

Thanks,

Cameron

Changed 22 months ago by jburke

  • milestone changed from 0.9 to 0.4.2

Changed 22 months ago by jburke

  • status changed from new to closed
  • resolution set to fixed

(In [7186]) Fixes #2301 and #2404, and references #2366. web built dojo.js now has strings interned, and for regular builds, all widget js files have strings interned now for the intern-strings target. To get those things to work, I moved the internStrings.js functions into buildUtil.js, but I did it slightly differently than the patch in #2301.

Changed 22 months ago by jburke

  • status changed from closed to closed
  • resolution set to fixed

(In [7187]) (merge from 0.4 branch) Fixes #2301 and #2404, and references #2366. web built dojo.js now has strings interned, and for regular builds, all widget js files have strings interned now for the intern-strings target. To get those things to work, I moved the internStrings.js functions into buildUtil.js, but I did it slightly differently than the patch in #2301.

Changed 18 months ago by anonymous

  • milestone deleted

Milestone 0.4.2 deleted

Note: See TracTickets for help on using tickets.