Ticket #2273 (closed defect: fixed)

Opened 23 months ago

Last modified 19 months ago

parameter usage in dojo.registerNamespaceManifest

Reported by: jeremy@… Owned by: sjmiles
Priority: normal Milestone:
Component: General Version: 0.4.1
Severity: normal Keywords:
Cc:

Description

I think there is a problem with dojo.registerNamespaceManifest.

dojo.registerNamespaceManifest = function(/*String*/module, /*String*/path, /*String*/name, /*String*/widgetModule, /*Function?*/resolver){

dojo.registerModulePath(name, path);

dojo.registerNamespace(name, widgetModule, resolver);

}

You can see that the 'module' input param is never used. I believe that the 'module' parameter should be used instead of the 'name' parameter in the first line of the function, giving you :

dojo.registerNamespaceManifest = function(/*String*/module, /*String*/path, /*String*/name, /*String*/widgetModule, /*Function?*/resolver){

dojo.registerModulePath(module, path);

dojo.registerNamespace(name, widgetModule, resolver);

}

The reason your namespace test passes is that you happen to use the same value for 'name' and 'module'. Using different values breaks this function.

Change History

Changed 23 months ago by peller

  • owner changed from anonymous to sjmiles

Changed 19 months ago by sjmiles

(In [8330]) Fix typo. Sorry this took so long to get fixed. :( Refs #2273.

Changed 19 months ago by sjmiles

  • status changed from new to closed
  • resolution set to fixed
Note: See TracTickets for help on using tickets.