Ticket #2196 (closed enhancement: fixed)

Opened 3 years ago

Last modified 3 years ago

Intern strings by looking for dojo.uri.Uri/moduleUri calls instead of templatePath/templateCssPath

Reported by: jburke Owned by: jburke
Priority: normal Milestone:
Component: BuildSystem Version: 0.4.1
Severity: normal Keywords:
Cc:

Description

Right now string interning does not work well for all widgets, because some widgets use other widget properties besides templatePath/templateCssPath to store the template URIs (Editor2 in particular).

So, look for dojo.uri calls instead, and if the file extension is .html, .htm, .txt or .css, then make a modified dojo.uri call that also includes the content of the URI as part of the dojo.uri call.

Then, in DomWidget?, look for this special property on the dojo.uri.Uri object (call it cachedContent for now), and if it is there, use it instead of trying to do a network request for the content.

Attachments

2196.patch (13.5 kB) - added by jburke 3 years ago.
2196 patch (excludes internStrings.js and dojo.uri.cache)
internStrings.js (5.9 kB) - added by jburke 3 years ago.
cache.js (0.8 kB) - added by jburke 3 years ago.

Change History

Changed 3 years ago by jburke

2196 patch (excludes internStrings.js and dojo.uri.cache)

Changed 3 years ago by jburke

Changed 3 years ago by jburke

Changed 3 years ago by jburke

  • status changed from new to closed
  • resolution set to fixed

(In [6929]) Fixes #2196: now have a intern-strings option for things that do not use templatePath and templateCssPath. Also moved intern-strings from python into javascript

Changed 3 years ago by jburke

(In [7046]) References #2196: now have a intern-strings option for things that do not use templatePath and templateCssPath. Also moved intern-strings from python into javascript (merge from trunk)

Changed 3 years ago by jburke

  • milestone changed from 0.9 to 0.4.2

Merged into 0.4 branch for 0.4.2.

Changed 3 years ago by anonymous

  • milestone deleted

Milestone 0.4.2 deleted

Note: See TracTickets for help on using tickets.