Menu: not fully destroyed (target nodes still bound)

[guest]

PopupMenu?2 initializers bind to the target nodes, but that is currently not undone when destroying the widget (this breaks any future menu functionality on those nodes).

The passive workaround is to unbind the target nodes before destroying:

    var menu = dojo.widget.byId('mymenu');
    dojo.lang.forEach(menu.targetNodeIds, menu.unBindDomNode, menu);
    menu.destroy();

I'm not sure what the proper override is in Menu2.js (Widget::cleanUp, Widget::uninitialize, Widget::destroyRendering ?), but a patch might look like this:

uninitialize: function(){
 dojo.lang.forEach(this.targetNodeIds, this.unBindDomNode, this);
}

[bill]

Yes, we need to cleanup the bindings to all nodes in this.targetNodeIds[], as well as any nodes that were bound to manual calls to bindDomNode(), and also just the binding to document.body itself (for window-level context menu).

I wish there were a way to delete all events that connect to a certain function.

[bill]

Hmm, I guess this is still an issue with the Dijit Menu.

[bill]

(In [11688]) Fix destruction issues with Menu. Fixes #1836. Refs #4902 (fixes it for Menu)

[bill]

(In [11735]) Fix regression in [11688] that was causing double destroy calls on same widget. Fixes #5326, Refs #1836, #4902.