Ticket #1663 (new defect)
fix loader.js comments and function names
| Reported by: | bill | Owned by: | jburke |
|---|---|---|---|
| Priority: | normal | Milestone: | 1.3 |
| Component: | General | Version: | 0.3 |
| Severity: | normal | Keywords: | |
| Cc: |
Description (last modified by bill) (diff)
As per the recent discussion to call dojo.html a module and dojo.html.common a resource... the comments and function/variable names in loader.js need to be updated. Here's a partial list of suggested updates:
- rename private functions to have _ in front of them
- rename loaded_modules --> loaded_resources
- rename startPackage --> startModule, or roll startPackage() code into dojo.provide(); unclear if a separate function is needed. in any case the comment for the function is confusing because it talks about creating javascript objects, which is more of an implementation detail than a guaranteed api. (contrast w/the comment for dojo.provide)
- rename findModule -> findResource
- loadPath - the comment should say it loads resources, or at the least, it shouldn't use the word "modules"
- modulesLoaded - could be resourcesLoaded? should probably have an underscore
- signature for addOnLoad/addOnUnload is better written as function(/*Object?*/obj, /*String|Function*/functionName). The first argument is optional and the second is mandatory.
Change History
Note: See
TracTickets for help on using
tickets.