Ticket #1425 (closed defect: fixed)

Opened 2 years ago

Last modified 18 months ago

accordion broken?

Reported by: bill Owned by: neil
Priority: normal Milestone:
Component: Widgets Version: 0.3
Severity: normal Keywords:
Cc:

Description

In test_Accordion.html, just click on Pane 1, Pane 2, Pane 3 repeatedly. Pane2 and Pane3 appear empty. Tested on IE6.

Attachments

html.js.BUG_TRAC_1425_716_864_866.patch (2.3 kB) - added by neil 2 years ago.
lfx utilities to correct functionality of wipein/wipeout for accordion widget, intended functionality and the testcase test_wipe.html; patch for $DOJO_ROOT/src/lfx/html.js
TitlePane.js.BUG_TRAC_1425_716_864_866.patch (0.7 kB) - added by neil 2 years ago.
Modification to $DOJO_ROOT/src/widget/TitlePane.js to accommodate updated lfx wipein/wipeout.
AccordionPane.js.BUG_TRAC_1425_716_864_866.patch (482 bytes) - added by neil 2 years ago.
Patch for $DOJO_ROOT/src/widget/AccordionPane.js to accommodate updated lfx.
test_wipe.html.BUG_TRAC_1425_716_864_866.patch (500 bytes) - added by neil 2 years ago.
Patch for $DOJO_ROOT/tests/animation/test_wipe.html; to be used with patched lfx to demonstrate intended wipein/wipeout functionality

Change History

Changed 2 years ago by neil

  • owner changed from bill to neil
  • status changed from new to assigned

Changed 2 years ago by neil

Modifications commited to lfx utilities have introduced characteristics incompatible with Accordion pane and for wipe/in/out features of lfx. Included are patches to correct behavior of lfx and patches to accordion/title pane to correct intended functionality. An updated patch to wipe functionality testcase for lfx is included. In the future it is wise to regression test modifications made to dojo code base prior to committing code.

Patches: AccordionPane?.js.BUG_TRAC_1425_716_864_866.patch, to be applied to $DOJO_ROOT/src/widget/AccordionPane.js, TitlePane?.js.BUG_TRAC_1425_716_864_866.patch, to be applied to $DOJO_ROOT/src/widget/TitlePane.js, html.js.BUG_TRAC_1425_716_864_866.patch, to be applied to $DOJO_ROOT/src/lfx/html.js test_wipe.html.BUG_TRAC_1425_716_864_866.patch, to be applied to $DOJO_ROOT/tests/animation/test_wipe.html

Patches/testcases tested with FF,opera and ie.

Changed 2 years ago by neil

lfx utilities to correct functionality of wipein/wipeout for accordion widget, intended functionality and the testcase test_wipe.html; patch for $DOJO_ROOT/src/lfx/html.js

Changed 2 years ago by neil

Modification to $DOJO_ROOT/src/widget/TitlePane.js to accommodate updated lfx wipein/wipeout.

Changed 2 years ago by neil

Patch for $DOJO_ROOT/src/widget/AccordionPane.js to accommodate updated lfx.

Changed 2 years ago by neil

Patch for $DOJO_ROOT/tests/animation/test_wipe.html; to be used with patched lfx to demonstrate intended wipein/wipeout functionality

Changed 2 years ago by bill

This regression was caused by lfx/html.js [5108], which fixed wipeIn/wipeOut for objects w/unspecified height, but broke Accordion (and other stuff too, maybe), because it hides objects by setting visibility:hidden rather than display:none.

This is a similar problem to the fadeIn/fadeOut discussions from a few months ago, where fadeIn/fadeOut would leave the object with display: block, opacity 0, rather than display: none (as I would have expected).

Changed 2 years ago by bill

  • status changed from assigned to closed
  • resolution set to fixed

Fixed in [5940] or earlier.

Changed 18 months ago by anonymous

  • milestone deleted

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.