Ticket #1368 (closed enhancement: fixed)

Opened 23 months ago

Last modified 2 weeks ago

Build option to remove console.* statements

Reported by: schallm Owned by: jburke
Priority: normal Milestone: 1.2
Component: BuildSystem Version: 0.3
Severity: normal Keywords:
Cc: jburke

Description

I just found the wonder of the dojo.profile namespace. I would like to add profile statements to all my widgets/modules. It would be great if the build system would remove them from the dojo.js file. Personally I would like to leave them in the rest of the release folder. Is the rest even even "built"?

Change History

Changed 23 months ago by dylan

  • milestone set to 0.4

Perhaps we can do this as part #1357 ?

Changed 22 months ago by dylan

  • milestone changed from 0.4 to 0.5

unfortunately not going to make it into 0.4, pushing to 0.5

Changed 12 months ago by peller

  • cc jburke added
  • milestone changed from 0.9 to 1.1

We don't have dojo.profile anymore, but there are profiling options on console, and we could possibly remove all console.* references in a build. Should we do this? This doesn't sound like a 0.9 thing.

Changed 8 months ago by dante

i'm +1 automatically stripping console.log/dir from the code in release builds (or any build for that matter?) ... they are helpful to in test cases, but have limited use within the codebase on a permanent basis.

Changed 5 months ago by dylan

  • summary changed from Build option to remove dojo.profile statements to Build option to remove console.* statements

Changed 5 months ago by peller

I'm -1 on removing some of the console.* statements, like console.error/warning. log and debug seem okay, but we need a 'style' statement about this before we change the build.

Changed 5 months ago by dylan

  • milestone changed from 1.1 to 1.2

ok, will push out until we decide on a preferred approach.

Changed 5 months ago by jburke

For this to work well, I'll need the parens-matching code needed for #2536.

Changed 4 months ago by jburke

  • owner changed from alex to jburke

Stealing from alex so it shows up in my bug search. Feel free to take it back if you really want it.

Changed 2 weeks ago by jburke

  • status changed from new to closed
  • resolution set to fixed

Fixed in r14254.

Changed 2 weeks ago by jburke

(In [14256]) Refs #1368: make sure console calls are still useful outside of built files that have the calls stripped.

Changed 2 weeks ago by jburke

(In [14258]) Refs #1368: make sure xdomain warnings are really warnings.

Changed 2 weeks ago by jburke

(In [14260]) Refs #1368: make sure xdomain warnings are really warnings. \!strict

Note: See TracTickets for help on using tickets.