Ticket #1286 (closed defect: fixed)

Opened 2 years ago

Last modified 18 months ago

Using reserved word "namespace" for some variable names

Reported by: jburke Owned by: peller
Priority: normal Milestone:
Component: General Version: 0.3
Severity: normal Keywords:
Cc:

Description

"namespace" is a reserved word for JavaScript?/ECMAScript. It is being used as a variable name at least in src/uri/Uri.js (for the nsUri function). The rest of the code should be scrubbed too.

See http://www.mozilla.org/js/language/es4/core/lexer.html

Attachments

namespace-r5427.patch (8.2 kB) - added by peller 2 years ago.
keyword patches to parser code
namespace-storage-r5427.patch (2.6 kB) - added by peller 2 years ago.
keyword patches to storage code

Change History

Changed 2 years ago by dylan

  • owner changed from anonymous to dylan
  • status changed from new to assigned

Changed 2 years ago by dylan

  • status changed from assigned to closed
  • resolution set to fixed

fixed in [5324]

Changed 2 years ago by peller

  • status changed from closed to reopened
  • resolution deleted

Sorry, Dylan, there are lots more of these, and I'm to blame. Most came from Shane's patch. I've been fixing them incrementally, but I need to do more.

Changed 2 years ago by peller

  • owner changed from dylan to peller
  • status changed from reopened to new

Changed 2 years ago by peller

as of now:

src/storage/browser.js src/widget/DomWidget.js src/widget/Manager.js src/widget/Parse.js src/widget/TreeV3.js src/widget/Widget.js src/xml/Parse.js src/namespace.js src/storage.js

Changed 2 years ago by peller

(In [5417]) references #1286 -- illegal use of namespace keyword

Changed 2 years ago by peller

keyword patches to parser code

Changed 2 years ago by peller

keyword patches to storage code

Changed 2 years ago by peller

(In [5464]) namespace keyword - references #1286

Changed 2 years ago by peller

  • status changed from new to closed
  • resolution set to fixed

(In [5465]) namespace keyword - fixes #1286

Changed 18 months ago by anonymous

  • milestone deleted

Milestone 0.4 deleted

Note: See TracTickets for help on using tickets.