Changeset 9675

Timestamp:

07/16/07 08:10:00 (18 months ago)

Author:

blowery

Message:

refs #3769, refs #3742. Revert change to enable native array iteration methods
on Safari3. The change fails the existing unit tests for array.js, and it does
not appear that Safari3's implementation is sufficient for dojo's forEach
contract. Specifically, forEach is not defined on String objects or null /
undefined values, so call against those types fail with a TypeError?.

We could insert an adapter that used the fast path on Safari3 when available
and fell back to the default Dojo implementation otherwise, but we'd need to
vet that technique with performance testing. For now, I'm just reverting the
change and we can figure out what we'd like to do long term.. later.

Location:

dojo/trunk

Files:

• tests/_base/array_via_prototype.html (deleted)
• _base/array.js (modified) (1 diff)

dojo/trunk/_base/array.js

@@ -4 +4 @@
 (function(){
         var d = dojo;
-        var tn = ["indexOf", "lastIndexOf", "every", "some", "forEach", "filter", "map"];
-        var makeCall = function(fn){
-                return function(a){
-                        a[fn].apply(a, Array.prototype.slice.call(arguments, 1));
-                }
-        };
         if(Array.forEach){
                 // fast, if we can
+                var tn = ["indexOf", "lastIndexOf", "every", "some", "forEach", "filter", "map"];
                 for(var x=0; x<tn.length; x++){
                         d[tn[x]] = Array[tn[x]];
-                }
-        }else if(Array.prototype.forEach){
-                // safari3 only exposes the fast methods on the prototype
-                for(var x=0; x<tn.length; x++){
-                        d[tn[x]] = makeCall(tn[x]);  // have to do this to bind the looped var
                 }
         }else{