Changeset 8927

Timestamp:

06/05/07 10:46:39 (19 months ago)

Author:

doughays

Message:

Fixes #3277. Proxy commit for haysmark.
A FilteringSelect? in Firefox with option tags but not value attribute gets its value set to the first option tag.
Added new test in test_FilteringSelect.html with no data at all.

Location:

dijit/trunk

Files:

• form/ComboBox.js (modified) (5 diffs)
• tests/form/test_FilteringSelect.html (modified) (1 diff)

dijit/trunk/form/ComboBox.js

@@ -331 +331 @@
                         //this.parentClass.onblur.apply(this, arguments);
                 },
-                
+
                 _announceOption: function(/*Node*/ node){
                         // summary:
@@ -342 +342 @@
                         this.focusNode.value=newValue;
                 },
-                
+
                 _selectOption: function(/*Event*/ evt){
                         var tgt = null;
@@ -418 +418 @@
                         var dpClass=dojo.getObject(this.dataProviderClass, false);
                         // is the store not specified?
+                        var data;
                         if(this.store==null){
                                 // if user didn't specify either url or data, then assume there are option tags
@@ -424 +425 @@
                                         var opts = this.domNode.getElementsByTagName("option");
                                         var ol = opts.length;
-                                        var data=[];
+                                        data=[];
                                         // go backwards to create the options list
                                         // have to go backwards because we are removing the option nodes
@@ -448 +449 @@
                         this.parentClass=dojo.getObject(this.declaredClass, false).superclass;
                         this.parentClass.postCreate.apply(this, arguments);
+
+                        // if there is no value set and there is an option list,
+                        // set the value to the first value to be consistent with native Select
+                        if(data&&data.length&&!this.getValue()){
+                                this.setDisplayedValue(data[0][this.searchAttr]);
+                        }
 
                         // convert the arrow image from using style.background-image to the .src property (a11y)

dijit/trunk/tests/form/test_FilteringSelect.html

@@ -254 +254 @@
         <div>Value: <input id="value8" disabled></div>
         <hr>
-
+        <p>FilteringSelect #9: No data</p>
+        <p>This FilteringSelect has no options to choose from.  It should still load.</p>
+        <select name="state9" dojoType="dijit.form.FilteringSelect" style="width: 300px;" autocomplete="false">
+        </select>
+        <br>
+        <hr>
         <input type="submit">
 </form>