Changeset 8470

Timestamp:

05/08/07 09:42:57 (20 months ago)

Author:

alex

Message:

patch from Ben Lowery for numeric additions to cookies. Refs #2796

Location:

dojo/trunk

Files:

• cookie.js (modified) (1 diff)
• tests/cookie.html (modified) (1 diff)

dojo/trunk/cookie.js

@@ -36 +36 @@
                 props = props || {};
                 value = encodeURIComponent(value);
-                if(typeof(props.expires) == "Number"){ 
+                if(typeof(props.expires) == "number"){ 
                         var d = new Date();
                         d.setTime(d.getTime()+(props.expires*24*60*60*1000));

dojo/trunk/tests/cookie.html

@@ -43 +43 @@
                                                                 t.is(v, dojo.cookie(n));
                                                         }
+                                                },
+                                                {
+                                                        name: "daysAsNumber",
+                                                        runTest: function(t){
+                                                                // set a cookie with a numerical expires
+                                                                dojo.cookie("dojo_num", "foo", { expires: 10 });
+                                                                t.is("foo", dojo.cookie("dojo_num"));
+                                                                
+                                                                // remove the cookie by setting it with a negative
+                                                                // numerical expires. value doesn't really matter here
+                                                                dojo.cookie("dojo_num", "-deleted-", { expires: -10 });
+                                                                t.is(null, dojo.cookie("dojo_num"));
+                                                        }
                                                 }
                                         ]