Changeset 7890

Timestamp:

04/01/07 02:10:53 (22 months ago)

Author:

alex

Message:

ensure that we actually play the "woohoo!" sound if it all goes well. Rate limits sounds. Refs #2550

Files:

• dojo/trunk/tests/_browserRunner.js (modified) (3 diffs)

dojo/trunk/tests/_browserRunner.js

@@ -213 +213 @@
                 }
 
+                var _nameTimes = {};
                 var _playSound = function(name){
-                        byId("hiddenAudio").innerHTML = '<embed src="_sounds/'+name+'.wav" autostart="true" loop="false" hidden="true" width="1" height="1"></embed>';
+                        var nt = _nameTimes[name];
+                        if((!nt)||(((new Date)-nt) > 700)){
+                                _nameTimes[name] = new Date();
+                                var tc = document.createElement("span");
+                                byId("hiddenAudio").appendChild(tc);
+                                tc.innerHTML = '<embed src="_sounds/'+name+'.wav" autostart="true" loop="false" hidden="true" width="1" height="1"></embed>';
+                        }
                 }
 
@@ -334 +341 @@
                 _addOnEvt("load", 
                         function(){
-                                if(loaded){ return; }
+                                tests._onEnd = function(){
+                                        if(tests._failureCount == 0){
+                                                tests.debug("WOOHOO!!");
+                                                _playSound("woohoo");
+                                        }else{
+                                                console.debug("tests._failureCount:", tests._failureCount);
+                                        }
+                                        toggleRunning();
+                                }
                                 if(!byId("play")){ 
                                         // make sure we've got an ammenable DOM structure
@@ -352 +367 @@
                                         }
                                 }
-                                tests._onEnd = function(){
-                                        toggleRunning();
-                                        if(tests._failureCount == 0){
-                                                alert("WOOHOO!!");
-                                                tests.debug("WOOHOO!!");
-                                                _playSound("woohoo");
-                                        }
-                                }
                                 tests.run = (function(oldRun){
                                         return function(){