Changeset 13345

Timestamp:

04/17/08 08:50:06 (7 months ago)

Author:

liucougar

Message:

fixes #6560: allow click event on button widget to propogate to match native browser behavior when clicking on a button with onclick="return false" specified

Files:

• dijit/trunk/form/Button.js (modified) (2 diffs)

dijit/trunk/form/Button.js

@@ -39 +39 @@
                 // summary: internal function to handle click actions
                 if(this.disabled || this.readOnly){
-                        dojo.stopEvent(e); // needed for checkbox
                         return false;
                 }
@@ -49 +48 @@
                 // summary: callback when the user mouse clicks the button portion
                 if(this._onClick(e) === false){ // returning nothing is same as true
-                        dojo.stopEvent(e);
+                        e.preventDefault(); // needed for checkbox
                 }else if(this.type=="submit" && !this.focusNode.form){ // see if a nonform widget needs to be signalled
                         for(var node=this.domNode; node.parentNode/*#5935*/; node=node.parentNode){