Changeset 13002

Timestamp:

03/10/08 14:04:21 (10 months ago)

Author:

elazutkin

Message:

dnd: removing dojo.marginBox() calls from all places in the DnD package,
adding new TimedMoveable? class, added a test for the new class.
Thx Douglas Hays for the idea of fps throttling on move, and for the
initial patch. Fixes #6132. Fixes #6133.

Location:

dojo/trunk

Files:

• dnd/Manager.js (modified) (1 diff)
• dnd/move.js (modified) (1 diff)
• dnd/Moveable.js (modified) (2 diffs)
• dnd/TimedMoveable.js (added)
• tests/dnd/test_timed_moveable.html (added)

dojo/trunk/dnd/Manager.js

@@ -100 +100 @@
                         //dojo.dnd.autoScrollNodes(e);
                         dojo.dnd.autoScroll(e);
-                        dojo.marginBox(a.node, {l: e.pageX + this.OFFSET_X, t: e.pageY + this.OFFSET_Y});
+                        //dojo.marginBox(a.node, {l: e.pageX + this.OFFSET_X, t: e.pageY + this.OFFSET_Y});
+                        var s = a.node.style;
+                        s.left = (e.pageX + this.OFFSET_X) + "px";
+                        s.top  = (e.pageY + this.OFFSET_Y) + "px";
                         var copy = Boolean(this.source.copyState(dojo.dnd.getCopyKeyState(e)));
                         if(this.copy != copy){ 

dojo/trunk/dnd/move.js

@@ -37 +37 @@
                 // summary: called during every move notification,
                 //      should actually move the node, can be overwritten.
-                var c = this.constraintBox;
-                leftTop.l = leftTop.l < c.l ? c.l : c.r < leftTop.l ? c.r : leftTop.l;
-                leftTop.t = leftTop.t < c.t ? c.t : c.b < leftTop.t ? c.b : leftTop.t;
-                dojo.marginBox(mover.node, leftTop);
+                var c = this.constraintBox, s = mover.node.style;
+                s.left = (leftTop.l < c.l ? c.l : c.r < leftTop.l ? c.r : leftTop.l) + "px";
+                s.top  = (leftTop.t < c.t ? c.t : c.b < leftTop.t ? c.b : leftTop.t) + "px";
         }
 });

dojo/trunk/dnd/Moveable.js

@@ -93 +93 @@
         onMoveStop: function(/* dojo.dnd.Mover */ mover){
                 // summary: called after every move operation
-                if(mover.timer){
-                        clearTimeout(mover.timer);
-                }
                 dojo.publish("/dnd/move/stop", [mover]);
                 dojo.removeClass(dojo.body(), "dojoMove");
@@ -109 +106 @@
                 // summary: called during every move notification,
                 //      should actually move the node, can be overwritten.
-                var _this = this;
-                mover.leftTop = leftTop;
-                if(!mover.timer){
-                        mover.timer = setTimeout(function(){
-                                mover.timer = null;
-                                var leftTop = mover.leftTop;
-                                _this.onMoving(mover, leftTop);
-                                dojo.marginBox(mover.node, leftTop);
-                                _this.onMoved(mover, leftTop);
-                        }, 0);
-                }
+                this.onMoving(mover, leftTop);
+                var s = mover.node.style;
+                s.left = leftTop.l + "px";
+                s.top  = leftTop.t + "px";
+                this.onMoved(mover, leftTop);
         },
         onMoving: function(/* dojo.dnd.Mover */ mover, /* Object */ leftTop){