Changeset 12796

Show
Ignore:
Timestamp:
02/29/08 19:29:54 (11 months ago)
Author:
peller
Message:

Fix RTL key nav for vertical tabs. Fixes #4508 !strict

Location:
dijit/trunk/layout
Files:
2 modified

Legend:

Unmodified
Added
Removed

  • dijit/trunk/layout/StackContainer.js

    r12792 r12796  
    360360                // TODO: this is a bit redundant with forward, back api in StackContainer 
    361361                adjacent: function(/*Boolean*/ forward){ 
    362                         if(!this.isLeftToRight()){ forward = !forward; } 
     362                        if(!this.isLeftToRight() && (!this.tabPosition || /top|bottom/.test(this.tabPosition))){ forward = !forward; } 
    363363                        // find currently focused button in children array 
    364364                        var children = this.getChildren(); 

  • dijit/trunk/layout/TabContainer.js

    r12795 r12796  
    140140         
    141141        _rectifyRtlTabList: function(){ 
    142                 //Summay: Rectify the length of all tabs in rtl, otherwise the tab lengths are different in IE 
     142                //Summary: Rectify the length of all tabs in rtl, otherwise the tab lengths are different in IE 
    143143                if(0 >= this.tabPosition.indexOf('-h')){ return; } 
    144144                if(!this.pane2button){ return; } 
     145 
    145146                var maxLen = 0; 
    146                 //this.tablist.pane2button is not array, so we can't use dojo.forEach here 
    147                 //simplily get the max length among the tabs 
    148147                for(var pane in this.pane2button){ 
    149                         var len = dojo.marginBox(this.pane2button[pane].innerDiv).w; 
    150                         maxLen = maxLen > len ? maxLen : len; 
     148                        maxLen = Math.max(maxLen, dojo.marginBox(this.pane2button[pane].innerDiv).w); 
    151149                } 
    152150                //unify the length of all the tabs