Changeset 12597

Timestamp:

02/21/08 13:35:03 (11 months ago)

Author:

doughays

Message:

Fixes #5917. Changed ComboBoxMixin? to use the _FormWidget:_onKeyPressed to manage undo.

Location:

dijit/trunk/form

Files:

• ComboBox.js (modified) (3 diffs)
• FilteringSelect.js (modified) (2 diffs)
• _FormWidget.js (modified) (1 diff)

dijit/trunk/form/ComboBox.js

@@ -76 +76 @@
 
                 baseClass:"dijitComboBox",
-
-                _lastDisplayedValue: "",
-
-                setDisplayedValue:function(/*String*/ value){
-                        this._lastDisplayedValue = value;
-                        this.setValue(value, true);
-                },
 
                 _getCaretPos: function(/*DomNode*/ element){
@@ -259 +252 @@
                                         this._prev_key_esc = true;
                                         this._hideResultList();
-                                        if(this._lastDisplayedValue != this.getDisplayedValue()){
-                                                this.setDisplayedValue(this._lastDisplayedValue);
-                                                dojo.stopEvent(evt);
-                                        }else{
-                                                this.setValue(this.getValue(), false);
-                                        }
+                                        this.inherited(arguments);
                                         break;
 
@@ -1054 +1042 @@
 
 
+

dijit/trunk/form/FilteringSelect.js

@@ -38 +38 @@
 
                 _isvalid:true,
+
+                _lastDisplayedValue: "",
 
                 isValid:function(){
@@ -218 +220 @@
                         dijit.form.MappedTextBox.prototype.setAttribute.apply(this, arguments);
                         dijit.form.ComboBoxMixin.prototype._setAttribute.apply(this, arguments);
+                },
+
+                undo: function(){
+                        this.setDisplayedValue(this._lastDisplayedValue);
+                },
+
+                _valueChanged: function(){
+                        return this.getDisplayedValue()!=this._lastDisplayedValue;
                 }
         }

dijit/trunk/form/_FormWidget.js

@@ -317 +317 @@
         },
 
+        _valueChanged: function(){
+                var v = this.getValue();
+                var lv = this._lastValueReported;
+                // Equality comparison of objects such as dates are done by reference so
+                // two distinct objects are != even if they have the same data. So use
+                // toStrings in case the values are objects.
+                return ((v !== null && (v !== undefined) && v.toString)?v.toString():null) !== ((lv !== null && (lv !== undefined) && lv.toString)?lv.toString():null);
+        },
+
         _onKeyPress: function(e){
                 if(e.keyCode == dojo.keys.ESCAPE && !e.shiftKey && !e.ctrlKey && !e.altKey){
-                        var v = this.getValue();
-                        var lv = this._lastValueReported;
-                        // Equality comparison of objects such as dates are done by reference so
-                        // two distinct objects are != even if they have the same data. So use
-                        // toStrings in case the values are objects.
-                        if(((v !== null && (v !== undefined) && v.toString)?v.toString():null) !== ((lv !== null && (lv !== undefined) && lv.toString)?lv.toString():null)){
+                        if(this._valueChanged()){
                                 this.undo();
                                 dojo.stopEvent(e);