Changeset 12184

Timestamp:

01/28/08 15:46:34 (12 months ago)

Author:

doughays

Message:

Fixes #5711 !strict. Did a global find of "document" object references in dijit/ and replaced with "dojo.doc".

Location:

dijit/trunk

Files:

• ColorPalette.js (modified) (1 diff)
• Dialog.js (modified) (1 diff)
• form/ComboBox.js (modified) (3 diffs)
• form/Textarea.js (modified) (4 diffs)
• form/ValidationTextBox.js (modified) (1 diff)
• InlineEditBox.js (modified) (1 diff)
• layout/BorderContainer.js (modified) (1 diff)
• layout/SplitContainer.js (modified) (4 diffs)
• layout/StackContainer.js (modified) (1 diff)
• layout/_LayoutWidget.js (modified) (1 diff)
• Menu.js (modified) (3 diffs)
• Tree.js (modified) (2 diffs)
• _base/place.js (modified) (1 diff)
• _base/popup.js (modified) (2 diffs)
• _base/wai.js (modified) (1 diff)
• _base/window.js (modified) (1 diff)
• _Calendar.js (modified) (1 diff)
• _editor/range.js (modified) (1 diff)
• _editor/RichText.js (modified) (5 diffs)
• _editor/selection.js (modified) (3 diffs)
• _TimePicker.js (modified) (2 diffs)

dijit/trunk/ColorPalette.js

@@ -113 +113 @@
                 for(var row=0; row < choices.length; row++){
                         for(var col=0; col < choices[row].length; col++) {
-                var highlightNode = document.createElement("img");
+                var highlightNode = dojo.doc.createElement("img");
                 highlightNode.src = url;
                 dojo.addClass(highlightNode, "dijitPaletteImg");

dijit/trunk/Dialog.js

@@ -310 +310 @@
 
                         this._modalconnects.push(dojo.connect(window, "onscroll", this, "layout"));
-                        this._modalconnects.push(dojo.connect(document.documentElement, "onkeypress", this, "_onKey"));
+                        this._modalconnects.push(dojo.connect(dojo.doc.documentElement, "onkeypress", this, "_onKey"));
 
                         dojo.style(this.domNode, "opacity", 0);

dijit/trunk/form/ComboBox.js

@@ -102 +102 @@
                         }else if(dojo.isIE){
                                 // in the case of a mouse click in a popup being handled,
-                                // then the document.selection is not the textarea, but the popup
-                                // var r = document.selection.createRange();
+                                // then the dojo.doc.selection is not the textarea, but the popup
+                                // var r = dojo.doc.selection.createRange();
                                 // hack to get IE 6 to play nice. What a POS browser.
-                                var tr = document.selection.createRange().duplicate();
+                                var tr = dojo.doc.selection.createRange().duplicate();
                                 var ntr = element.createTextRange();
                                 tr.move("character",0);
@@ -154 +154 @@
                                 var tcc = tchar.charCodeAt(0);
                                 for(var x = 0; x < dist; x++){
-                                        var te = document.createEvent("KeyEvents");
+                                        var te = dojo.doc.createEvent("KeyEvents");
                                         te.initKeyEvent("keypress", true, true, null, false, false, false, false, tcc, tcc);
                                         element.dispatchEvent(te);
@@ -733 +733 @@
 
                         var labelObject = labelFunc(item);
-                        var menuitem = document.createElement("div");
+                        var menuitem = dojo.doc.createElement("div");
                         if(labelObject.html){
                                 menuitem.innerHTML = labelObject.label;
                         }else{
                                 menuitem.appendChild(
-                                        document.createTextNode(labelObject.label)
+                                        dojo.doc.createTextNode(labelObject.label)
                                 );
                         }

dijit/trunk/form/Textarea.js

@@ -65 +65 @@
                                         if(isFirst){ isFirst = false; }
                                         else{
-                                                editNode.appendChild(document.createElement("BR")); // preserve line breaks
+                                                editNode.appendChild(dojo.doc.createElement("BR")); // preserve line breaks
                                         }
                                         if(line){
-                                                editNode.appendChild(document.createTextNode(line)); // use text nodes so that imbedded tags can be edited
+                                                editNode.appendChild(dojo.doc.createTextNode(line)); // use text nodes so that imbedded tags can be edited
                                         }
                                 });
                         }else if(value){
-                                editNode.appendChild(document.createTextNode(value));
+                                editNode.appendChild(dojo.doc.createTextNode(value));
                         }
                         if(!dojo.isIE){
-                                editNode.appendChild(document.createElement("BR")); // so that you see a cursor
+                                editNode.appendChild(dojo.doc.createElement("BR")); // so that you see a cursor
                         }
                 }else{
@@ -93 +93 @@
                 this.value = this.formValueNode.value = value;
                 if(this.iframe){
-                        var sizeNode = document.createElement('div');
+                        var sizeNode = dojo.doc.createElement('div');
                         editNode.appendChild(sizeNode);
                         var newHeight = sizeNode.offsetTop;
@@ -149 +149 @@
                                 this._iframeEditTitle = label[0].innerHTML + " " + this._iframeEditTitle;
                         }
-                        var body = this.focusNode = this.editNode = document.createElement('BODY');
+                        var body = this.focusNode = this.editNode = dojo.doc.createElement('BODY');
                         body.style.margin="0px";
                         body.style.padding="0px";
@@ -236 +236 @@
                         // it will not hear anything.
                         // Create an equivalent event so everyone else knows what is going on.
-                        var te = document.createEvent("KeyEvents");
+                        var te = dojo.doc.createEvent("KeyEvents");
                         te.initKeyEvent("keypress", true, true, null, e.ctrlKey, e.altKey, e.shiftKey, e.metaKey, e.keyCode, e.charCode);
                         this.iframe.dispatchEvent(te);

dijit/trunk/form/ValidationTextBox.js

@@ -192 +192 @@
                 postCreate: function(){
                         var textbox = this.textbox;
-                        var valueNode = (this.valueNode = document.createElement("input"));
+                        var valueNode = (this.valueNode = dojo.doc.createElement("input"));
                         valueNode.setAttribute("type", textbox.type);
                         valueNode.setAttribute("value", this.toString());

dijit/trunk/InlineEditBox.js

@@ -138 +138 @@
                 // Put place holder (and eventually editWidget) before the display node so that it's positioned correctly
                 // when Calendar dropdown appears, which happens automatically on focus.
-                var placeholder = document.createElement("span");
+                var placeholder = dojo.doc.createElement("span");
                 dojo.place(placeholder, this.domNode, "before");
 

dijit/trunk/layout/BorderContainer.js

@@ -244 +244 @@
                         if(this._right){ borderBox(this._right, {h: sidebarHeight}); }
 
-                        if(dojo.isIE && (document.compatMode == "BackCompat" || dojo.isIE < 7)){
+                        if(dojo.isIE && (dojo.doc.compatMode == "BackCompat" || dojo.isIE < 7)){
 //TODO: use dojo.marginBox instead of dojo.style?
 /*

dijit/trunk/layout/SplitContainer.js

@@ -60 +60 @@
                         }catch(e){ this.sizerWidth = 7; }
                 }
-                var sizer = this.virtualSizer = document.createElement('div');
+                var sizer = this.virtualSizer = dojo.doc.createElement('div');
                 sizer.style.position = 'relative';
 
@@ -110 +110 @@
 
                 // TODO: use a template for this!!!
-                var sizer = this.sizers[i] = document.createElement('div');
+                var sizer = this.sizers[i] = dojo.doc.createElement('div');
                 this.domNode.appendChild(sizer);
 
@@ -116 +116 @@
 
                 // add the thumb div
-                var thumb = document.createElement('div');
+                var thumb = dojo.doc.createElement('div');
                 thumb.className = 'thumb';
                 sizer.appendChild(thumb);
@@ -386 +386 @@
                 //
                 this._ownconnects = [];
-                this._ownconnects.push(dojo.connect(document.documentElement, "onmousemove", this, "changeSizing"));
-                this._ownconnects.push(dojo.connect(document.documentElement, "onmouseup", this, "endSizing"));
+                this._ownconnects.push(dojo.connect(dojo.doc.documentElement, "onmousemove", this, "changeSizing"));
+                this._ownconnects.push(dojo.connect(dojo.doc.documentElement, "onmouseup", this, "endSizing"));
 
                 dojo.stopEvent(e);

dijit/trunk/layout/StackContainer.js

@@ -276 +276 @@
 
                         // add a node that will be promoted to the button widget
-                        var refNode = document.createElement("span");
+                        var refNode = dojo.doc.createElement("span");
                         this.domNode.appendChild(refNode);
                         // create an instance of the button widget

dijit/trunk/layout/_LayoutWidget.js

@@ -20 +20 @@
                         // summary:
                         //              Called after all the widgets have been instantiated and their
-                        //              dom nodes have been inserted somewhere under document.body.
+                        //              dom nodes have been inserted somewhere under dojo.doc.body.
                         //
                         //              Widgets should override this method to do any initialization

dijit/trunk/Menu.js

@@ -151 +151 @@
                         // Moz. TODO: is this available when defaultView isn't?
                         dijit.Menu._iframeContentDocument(iframe_el)['__parent__'] ||
-                        (iframe_el.name && document.frames[iframe_el.name]) || null;
+                        (iframe_el.name && dojo.doc.frames[iframe_el.name]) || null;
                 return win;     //      Window
         },
@@ -160 +160 @@
                 var doc = iframe_el.contentDocument // W3
                         || (iframe_el.contentWindow && iframe_el.contentWindow.document) // IE
-                        || (iframe_el.name && document.frames[iframe_el.name] && document.frames[iframe_el.name].document)
+                        || (iframe_el.name && dojo.doc.frames[iframe_el.name] && dojo.doc.frames[iframe_el.name].document)
                         || null;
                 return doc;     //      HTMLDocument
@@ -427 +427 @@
 
                 // we didn't copy the dropdown widget from the this.srcNodeRef, so it's in no-man's
-                // land now.  move it to document.body.
+                // land now.  move it to dojo.doc.body.
                 if(!this.popup){
                         var node = dojo.query("[widgetId]", this.dropDownContainer)[0];

dijit/trunk/Tree.js

@@ -140 +140 @@
         setLabelNode: function(label){
                 this.labelNode.innerHTML="";
-                this.labelNode.appendChild(document.createTextNode(label));
+                this.labelNode.appendChild(dojo.doc.createTextNode(label));
         },
 
@@ -341 +341 @@
                 // make template for container node (we will clone this and insert it into
                 // any nodes that have children)
-                var div = document.createElement('div');
+                var div = dojo.doc.createElement('div');
                 div.style.display = 'none';
                 div.className = "dijitTreeContainer";   

dijit/trunk/_base/place.js

@@ -102 +102 @@
 
         // This won't work if the node is inside a <div style="position: relative">,
-        // so reattach it to document.body.   (Otherwise, the positioning will be wrong
+        // so reattach it to dojo.doc.body.   (Otherwise, the positioning will be wrong
         // and also it might get cutoff)
         if(!node.parentNode || String(node.parentNode.tagName).toLowerCase() != "body"){

dijit/trunk/_base/popup.js

@@ -19 +19 @@
                 //
                 // description:
-                //              Attaches node to document.body, and
+                //              Attaches node to dojo.doc.body, and
                 //              positions it off screen, but not display:none, so that
                 //              the widget doesn't appear in the page flow and/or cause a blank
@@ -246 +246 @@
                 node.appendChild(iframe);
                 if(dojo.isIE){
-                        iframe.style.setExpression("width", "document.getElementById('" + node.id + "').offsetWidth");
-                        iframe.style.setExpression("height", "document.getElementById('" + node.id + "').offsetHeight");
+                        iframe.style.setExpression("width", "dojo.doc.getElementById('" + node.id + "').offsetWidth");
+                        iframe.style.setExpression("height", "dojo.doc.getElementById('" + node.id + "').offsetHeight");
                 }
                 this.iframe = iframe;

dijit/trunk/_base/wai.js

@@ -14 +14 @@
                 var div;
                 // create div for testing if high contrast mode is on or images are turned off
-                div = document.createElement("div");
+                div = dojo.doc.createElement("div");
                 div.id = "a11yTestNode";
                 div.style.cssText = 'border: 1px solid;'

dijit/trunk/_base/window.js

@@ -20 +20 @@
         }
 
-        //In some IE versions (at least 6.0), document.parentWindow does not return a
+        //In some IE versions (at least 6.0), dojo.doc.parentWindow does not return a
         //reference to the real window object (maybe a copy), so we must fix it as well
         //We use IE specific execScript to attach the real window reference to
         //document._parentWindow for later use
-        if(dojo.isIE && window !== document.parentWindow && !doc._parentWindow){
+        if(dojo.isIE && window !== dojo.doc.parentWindow && !doc._parentWindow){
                 /*
                 In IE 6, only the variable "window" can be used to connect events (others
                 may be only copies).
                 */
-                doc.parentWindow.execScript("document._parentWindow = window;", "Javascript");
+                doc.parentWindow.execScript("dojo.doc._parentWindow = window;", "Javascript");
                 //to prevent memory leak, unset it after use
                 //another possibility is to add an onUnload handler which seems overkill to me (liucougar)

dijit/trunk/_Calendar.js

@@ -61 +61 @@
                                 node.removeChild(node.firstChild);
                         }
-                        node.appendChild(document.createTextNode(text));
+                        node.appendChild(dojo.doc.createTextNode(text));
                 },
 

dijit/trunk/_editor/range.js

@@ -187 +187 @@
 dijit.range.create = function(){
         if(dijit.range._w3c){
-                return document.createRange();
+                return dojo.doc.createRange();
         }else{//IE
                 return new dijit.range.W3CRange;

dijit/trunk/_editor/RichText.js

@@ -7 +7 @@
 
 // used to restore content when user leaves this page then comes back
-// but do not try doing document.write if we are using xd loading.
-// document.write will only work if RichText.js is included in the dojo.js
+// but do not try doing dojo.doc.write if we are using xd loading.
+// dojo.doc.write will only work if RichText.js is included in the dojo.js
 // file. If it is included in dojo.js and you want to allow rich text saving
 // for back/forward actions, then set dojo.config.allowXdRichTextSave = true.
@@ -206 +206 @@
                 }
                 //queryCommandValue returns empty if we hide editNode, so move it out of screen temporary
-                var div=document.createElement('div');
+                var div=dojo.doc.createElement('div');
                 div.style.position = "absolute";
                 div.style.left = "-2000px";
                 div.style.top = "-2000px";
-                document.body.appendChild(div);
+                dojo.doc.body.appendChild(div);
                 div.innerHTML = localhtml;
                 var node = div.firstChild;
@@ -217 +217 @@
                         dojo.withGlobal(this.window, "selectElement", dijit._editor.selection, [node.firstChild]);
                         var nativename = node.tagName.toLowerCase();
-                        this._local2NativeFormatNames[nativename] = document.queryCommandValue("formatblock");//this.queryCommandValue("formatblock");
+                        this._local2NativeFormatNames[nativename] = dojo.doc.queryCommandValue("formatblock");//this.queryCommandValue("formatblock");
                         this._native2LocalFormatNames[this._local2NativeFormatNames[nativename]] = nativename;
                         node = node.nextSibling;
                 }
-                document.body.removeChild(div);
+                dojo.doc.body.removeChild(div);
         },
 
@@ -328 +328 @@
                 // Safari's selections go all out of whack if we do it inline,
                 // so for now IE is our only hero
-                //if (typeof document.body.contentEditable != "undefined") {
+                //if (typeof dojo.doc.body.contentEditable != "undefined") {
                 if(dojo.isIE || dojo.isSafari || dojo.isOpera){ // contentEditable, easy
                         var ifr = this.iframe = dojo.doc.createElement('iframe');
@@ -433 +433 @@
                         ifr.id=this.id;
                         // this.iframe.src = "about:blank";
-                        // document.body.appendChild(this.iframe);
+                        // dojo.doc.body.appendChild(this.iframe);
                         // console.debug(this.iframe.contentDocument.open());
                         // dojo.body().appendChild(this.iframe);

dijit/trunk/_editor/selection.js

@@ -8 +8 @@
 dojo.mixin(dijit._editor.selection, {
         getType: function(){
-                // summary: Get the selection type (like document.select.type in IE).
+                // summary: Get the selection type (like dojo.doc.select.type in IE).
                 if(dojo.doc.selection){ //IE
                         return dojo.doc.selection.type.toLowerCase();
@@ -62 +62 @@
                         if(selection && selection.rangeCount){
                                 var frag = selection.getRangeAt(0).cloneContents();
-                                var div = document.createElement("div");
+                                var div = dojo.doc.createElement("div");
                                 div.appendChild(frag);
                                 return div.innerHTML;
@@ -167 +167 @@
                            selection.collapse(beginning);
                   }
-          }else if(document.selection){ // IE
+          }else if(dojo.doc.selection){ // IE
                   var range = dojo.doc.selection.createRange();
                   range.collapse(beginning);

dijit/trunk/_TimePicker.js

@@ -137 +137 @@
                 _createOption:function(/*Number*/ index){
                         // summary: creates a clickable time option
-                        var div=document.createElement("div");
+                        var div=dojo.doc.createElement("div");
                         var date = (div.date = new Date(this._refDate));
                         div.index=index;
@@ -145 +145 @@
                                 date.getSeconds()+incrementDate.getSeconds()*index);
 
-                        var innerDiv = document.createElement('div');
+                        var innerDiv = dojo.doc.createElement('div');
                         dojo.addClass(div,this.baseClass+"Item");
                         dojo.addClass(innerDiv,this.baseClass+"ItemInner");