Changeset 11988

Timestamp:

01/10/08 08:29:45 (7 months ago)

Author:

peller

Message:

some reductions (=== undefined) and style mods. Refs #5542

Files:

• dojo/trunk/_base/NodeList.js (modified) (8 diffs)

dojo/trunk/_base/NodeList.js

@@ -195 +195 @@
                         //              an Array (*not* a NodeList)
                         
-                        return d.map(this, d.coords);
+                        return d.map(this, d.coords); // Array
                 },
 
@@ -259 +259 @@
                         //              or an offset in the childNodes property
                         var item = d.query(queryOrNode)[0];
-                        position = position||"last";
+                        position = position || "last";
 
                         for(var x=0; x<this.length; x++){
@@ -306 +306 @@
                         //      simpleFilter: single-expression CSS filter
                         //      return: a dojo.NodeList of all of the elements orpahned
-                        var orphans = (simpleFilter) ? d._filterQueryResult(this, simpleFilter) : this;
+                        var orphans = simpleFilter ? d._filterQueryResult(this, simpleFilter) : this;
                         orphans.forEach(function(item){
-                                if(item["parentNode"]){
+                                if(item.parentNode){
                                         item.parentNode.removeChild(item);
                                 }
@@ -332 +332 @@
                         //              or an offset in the childNodes property
                         var item = this[0];
-                        return d.query(queryOrListOrNode).forEach(function(ai){ d.place(ai, item, (position||"last")); }); // dojo.NodeList
+                        return d.query(queryOrListOrNode).forEach(function(ai){ d.place(ai, item, position || "last"); }); // dojo.NodeList
                 },
 
@@ -342 +342 @@
                         //              current NodeList as query roots.
 
-                        if(!queryStr){ return this; };
+                        if(!queryStr){ return this; }
 
                         // FIXME: probably slow
+                        // FIXME: use map?
                         var ret = d.NodeList();
                         this.forEach(function(item){
                                 d.query(queryStr, item).forEach(function(subItem){
-                                        if(typeof subItem != "undefined"){
+                                        if(subItem !== undefined){
                                                 ret.push(subItem);
                                         }
@@ -375 +376 @@
                         var r = d.NodeList();
                         var rp = function(t){ 
-                                if(typeof t != "undefined"){
+                                if(t !== undefined){
                                         r.push(t); 
                                 }
@@ -386 +387 @@
                                 }
                                 // if we got a callback, run it over the filtered items
-                                d.forEach(d.filter(items, _a[1], _a[2]), rp);
-                                return r; // dojo.NodeList
+                                _a.shift();
                         }
                         // handle the (callback, [thisObject]) case
                         d.forEach(d.filter(items, _a[0], _a[1]), rp);
                         return r; // dojo.NodeList
-
                 },
                 
@@ -437 +436 @@
                                 ta.appendChild(content);
                         }
-                        if(typeof position == "undefined"){
+                        if(position === undefined){
                                 position = "last";
                         }
-                        var ct = ((position == "first")||(position == "after")) ? "lastChild" : "firstChild";
+                        var ct = (position == "first" || position == "after") ? "lastChild" : "firstChild";
                         this.forEach(function(item){
                                 var tn = ta.cloneNode(true);