Changeset 10203

Timestamp:

08/15/07 20:51:12 (15 months ago)

Author:

peller

Message:

pick up a couple more bytes from array. Use xor bitwise logic on booleans. Refs #3961

Files:

• dojo/trunk/_base/array.js (modified) (3 diffs)

dojo/trunk/_base/array.js

@@ -19 +19 @@
                         //                      http://developer.mozilla.org/en/docs/Core_JavaScript_1.5_Reference:Global_Objects:Array:indexOf
 
-                        var step;
+                        var i = 0, step = 1, end = array.length;
                         if(findLast){
-                                step = -1, i = (fromIndex||array.length - 1), end = -1;
-                        }else{
-                                step = 1, i = (fromIndex||0), end = array.length;
+                                i = end - 1;
+                                step = end = -1;
                         }
-                        for(; i!=end; i+=step){
+                        for(i = fromIndex || i; i != end; i += step){
                                 if(array[i] == value){ return i; }
                         }
@@ -52 +51 @@
 
                         // match the behavior of the built-in forEach WRT empty arrs
-                        if((!arr)||(!arr.length)){ return; }
+                        if(!arr || !arr.length){ return; }
 
                         // FIXME: there are several ways of handilng thisObject. Is
@@ -64 +63 @@
                 _everyOrSome: function(/*Boolean*/every, /*Array*/arr, /*Function*/callback, /*Object?*/obj){
                         var _p = _getParts(arr, obj); arr = _p[0]; obj = _p[1];
-                        for(var i=0,l=arr.length; i<l; i++){
-                                var result = callback.call(obj, arr[i], i, arr);
-                                if(every && !result){
-                                        return false; // Boolean
-                                }else if((!every)&&(result)){
-                                        return true; // Boolean
+                        for(var i = 0, l = arr.length; i < l; i++){
+                                var result = !!callback.call(obj, arr[i], i, arr);
+                                if(every ^ result){
+                                        return result; // Boolean
                                 }
                         }
-                        return (!!every); // Boolean
+                        return every; // Boolean
                 },